The function was never called, since the worker thread was never exiting. Also it was incomplete (not clearing pending job list) and mixing global queue and argument. Let's remove it.
Note: maybe the worker thread could be torn down when vnc_jobs_join() realizes there is no job left. Signed-off-by: Marc-André Lureau <[email protected]> --- ui/vnc-jobs.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c index 9e536b07b90..28a4738f1ec 100644 --- a/ui/vnc-jobs.c +++ b/ui/vnc-jobs.c @@ -345,14 +345,6 @@ static VncJobQueue *vnc_queue_init(void) return queue; } -static void vnc_queue_clear(VncJobQueue *q) -{ - qemu_cond_destroy(&queue->cond); - qemu_mutex_destroy(&queue->mutex); - g_free(q); - queue = NULL; /* Unset global queue */ -} - static void *vnc_worker_thread(void *arg) { VncJobQueue *queue = arg; @@ -360,7 +352,7 @@ static void *vnc_worker_thread(void *arg) qemu_thread_get_self(&queue->thread); while (!vnc_worker_thread_loop(queue)) ; - vnc_queue_clear(queue); + g_assert_not_reached(); return NULL; } -- 2.53.0
