On Tue, Mar 17, 2026 at 12:50:21PM +0400, Marc-André Lureau wrote: > The function was never called, since the worker thread was never > exiting. Also it was incomplete (not clearing pending job list) and > mixing global queue and argument. Let's remove it. > > Note: maybe the worker thread could be torn down when vnc_jobs_join() > realizes there is no job left.
Dynamically starting and stopping the worker thread would mean having to think about possible race conditions. Simpler to ignore that possibility IMHO. > > Signed-off-by: Marc-André Lureau <[email protected]> > --- > ui/vnc-jobs.c | 10 +--------- > 1 file changed, 1 insertion(+), 9 deletions(-) Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
