On Tue, Mar 17, 2026 at 12:50:20PM +0400, Marc-André Lureau wrote:
> Since commit 09526058d0a5 ("ui/vnc: Remove vnc_stop_worker_thread()"),
> it's not used anymore. It seems stopping worker thread hasn't been
> supported ever.Yeah seems vnc_stop_worker_thread was dead code since the first commit in bd023f953e5e51237726af04300e4637fe203774. Not a problem, as long as we do NOT have the ability to dynamically add/remove VNC display backends via QMP. If we get get that then I wouldn't trust 16 year old code for stopping the worker that has never been exercised ! > Signed-off-by: Marc-André Lureau <[email protected]> > --- > ui/vnc-jobs.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
