On Fri, 08 May 2026 12:24:20 +0100, Daniel P. Berrangé <[email protected]> wrote: > diff --git a/qom/trace-events b/qom/trace-events > index b2e9f4a7127..9aabbae4f73 100644 > --- a/qom/trace-events > +++ b/qom/trace-events > @@ -1,5 +1,13 @@ > # See docs/devel/tracing.rst for syntax documentation. > > # object.c > -object_dynamic_cast_assert(const char *type, const char *target, const char > *file, int line, const char *func) "%s->%s (%s:%d:%s)" > -object_class_dynamic_cast_assert(const char *type, const char *target, const > char *file, int line, const char *func) "%s->%s (%s:%d:%s)" > +object_dynamic_cast_assert(void *obj, const char *type, const char *target, > const char *file, int line, const char *func) "obj=%p type=%s->%s (%s:%d:%s)" > +object_finalize(void *obj, const char *type) "obj=%p type=%s" > +object_new(void *obj, const char *type) "obj=%p type=%s" > +object_property_add(void *obj, const char *type, const char *name, void > *value) "obj=%p type=%s name=%s value=%p" > +object_property_add_child(void *obj, const char *type, const char *name, > void *parent, const char *parenttype) "obj=%p type=%s name=%s parent=%p > parent-type=%s"
The 4th and 5th parameters are the child being added, not a parent. In object_property_try_add_child the call is: trace_object_property_add_child(obj, ..., child, child->class->type->name) So the parameter names should be "child"/"childtype" and the format string should use "child=" / "child-type=". > +object_property_del(void *obj, const char *type, const char *name, void > *value) "obj=%p type=%s name=%s value=%p" > +object_property_del_child(void *obj, const char *type, void *parent, const > char *parenttype) "obj=%p type=%s parent=%p parent-type=%s" Same here -- Marc-André Lureau <[email protected]>
