On Fri, May 08, 2026 at 07:18:29PM +0400, [email protected] wrote:
> On Fri, 08 May 2026 12:24:26 +0100, Daniel P. Berrangé <[email protected]> 
> wrote:
> > diff --git a/include/qom/object.h b/include/qom/object.h
> > index 1b2b2702fc9..cd59f1f1718 100644
> > --- a/include/qom/object.h
> > +++ b/include/qom/object.h
> > @@ -700,6 +700,25 @@ Object *object_new_with_propv(const char *typename,
> > [ ... skip 13 lines ... ]
> > + * properties in a QDict.
> > + */
> > +Object *object_new_with_props_from_qdict(const char *typename,
> > +                                         Object *parent,
> > +                                         const char *id,
> > +                                         QDict *props,
> 
> This should take a const QDict, same for the _parentless added later.

Ah yes, that would match the existing object_set_props_from_qdict
signature.

With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|


Reply via email to