On 5/19/26 09:22, James Hilliard wrote:
+/*
+ * The shared HSH/SHA3/SNOW3G/ZUC register window needs selector-position
+ * arithmetic.  Instruction dispatch itself is still fully decoded by
+ * decodetree and calls per-operation helpers.
+ */
+#define OCTEON_HSH_DATW(N)          (0x0240u + (N))
+#define OCTEON_HSH_IVW(N)           (0x0250u + (N))
+#define OCTEON_SHA3_DAT24_SEL       0x0050u
+#define OCTEON_SHA3_DAT15_MT_SEL    0x0051u
+#define OCTEON_SHA3_DAT15_MF_SEL    OCTEON_HSH_DATW(15)
+#define OCTEON_SNOW3G_LFSR(N)       OCTEON_HSH_DATW(N)
+#define OCTEON_SNOW3G_RESULT_SEL    OCTEON_HSH_IVW(0)
+#define OCTEON_SNOW3G_FSM(N)        OCTEON_HSH_IVW(1 + (N))

What are these for?  The MF/MT offsets should be irrelevant now.


+
+static inline void octeon_set_shared_mode(MIPSOcteonCryptoState *crypto,
+                                          MIPSOcteonSharedMode mode)
+{
+    crypto->shared_mode = mode;
+}


Unused function.  This patch won't compile with clang.
Also, as I mentioned against the previous patch, I think shared_mode is an 
error.


r~

Reply via email to