On Tue, 9 Jun 2026 13:47:09 +0100, Jonathan Cameron <[email protected]> wrote:
Hi Jonathan,
Thanks for the detailed review!
> It may be a good idea to add a bios tables test as well.
Okay. I'll add a RISC-V ACPI bios tables test in v2 to cover
the _DEP additions and prevent regressions.
> Please also include an iasl -d dump of the relevant additions to DSDT
> in the patch description. Much easier to review than the code that
> generates it!
Will do. I'll include the iasl -d decompiled output of the ACPI0017
device (with _DEP) in the v2 commit message.
> In general looks fine to me and great that you are clearing this up.
> Seems it's luck that x86 and ARM64 worked without this (or strictly
> speaking other things enforcing the ordering). Ultimately we probably
> want to add this to those two architectures as well.
Agreed. I can send a follow-up series to add _DEP for x86/ARM64
once this lands on RISC-V.
> > + if (s->bus) {
> > + PCIBus *bus;
> > + uint32_t num_cxl_hbs = 0;
> > +
> > + QLIST_FOREACH(bus, &s->bus->child, sibling) {
> > + if (pci_bus_is_root(bus) && pci_bus_is_cxl(bus)) {
> > + num_cxl_hbs++;
>
> I think you only care if there is at least one. Instead of counting, just set
> a bool and break out early if you find one.
As Peter pointed out, the count is actually needed for
aml_package(num_cxl_hbs) to set the correct number of elements.
We'd need two loops regardless (one to count, one to populate), so
I'll keep the current structure.
Best,
Pei
