On 19.06.26 09:15, Michael Tokarev wrote:
> On 19.06.2026 10:12, Mathias Krause wrote:
>
>>>> - after the change:
>>>> (gdb) info registers cr4
>>>> cr4 0x8000f0 [ CET PGE MCE PAE PSE ]
>
>> Would be nice if it could be included in a 11.x release, as that's the
>> first with CET virtualization support.
>
> Hmm. So it looks like this change is wrong for previous releases
> (10.0, 10.2), and should not be picked up there, right?
It's not wrong, it's providing symbolic names to architecturally defined
control register bits. If a guest doesn't use these (because it cannot
because of QEMU/KVM lacking virtualization support for them), they just
won't be used but they're still correct.
Looking at the git history, it looks like QEMU gained PKS support in
e7e7bdababee ("target/i86: implement PKS"), which was v6.0. So this
change should be backported to all still supported branches, imho.
Thanks,
Mathias
