Alex Bennée <[email protected]> writes: > Jim MacArthur <[email protected]> writes: > >> We autodetect the presence of FPRCVT in the test cross compiler, >> which is a recent feature in GCC and not supported by many distros >> yet. If this is in place, we compile the existing fcvt.c test with >> an extra compiler flag which uses the new SIMD instructions; the >> output from the test is unchanged. >> >> The existing [US]CVTF instructions do not have a test, so no new >> tests are added for the SIMD versions. They have been tested manually >> to check the new SIMD versions produce the same numerical results as >> the existing versions. >> >> Signed-off-by: Jim MacArthur <[email protected]> >> --- >> tests/tcg/aarch64/Makefile.target | 14 +++++++++++++- >> tests/tcg/arm/fcvt.c | 7 +++++++ >> 2 files changed, 20 insertions(+), 1 deletion(-) >> >> diff --git a/tests/tcg/aarch64/Makefile.target >> b/tests/tcg/aarch64/Makefile.target >> index 6203ac9b51..32f2689273 100644 >> --- a/tests/tcg/aarch64/Makefile.target >> +++ b/tests/tcg/aarch64/Makefile.target >> @@ -28,9 +28,21 @@ config-cc.mak: Makefile >> $(call cc-option,-march=armv8.5-a, >> CROSS_CC_HAS_ARMV8_5); \ >> $(call cc-option,-mbranch-protection=standard, >> CROSS_CC_HAS_ARMV8_BTI); \ >> $(call cc-option,-march=armv8.5-a+memtag, >> CROSS_CC_HAS_ARMV8_MTE); \ >> - $(call cc-option,-Wa$(COMMA)-march=armv9-a+sme $$fnia, >> CROSS_AS_HAS_ARMV9_SME)) 3> config-cc.mak >> + $(call cc-option,-Wa$(COMMA)-march=armv9-a+sme $$fnia, >> CROSS_AS_HAS_ARMV9_SME); \ >> + $(call cc-option,-march=armv9-a+fprcvt, >> CROSS_CC_HAS_ARMV9_FPRCVT)) 3> config-cc.mak >> -include config-cc.mak >> >> +ifneq ($(CROSS_CC_HAS_ARMV9_FPRCVT),) >> +AARCH64_TESTS += fcvt-fprcvt >> +fcvt-fprcvt: LDFLAGS += -lm >> +fcvt-fprcvt: CFLAGS += $(CROSS_CC_HAS_ARMV9_FPRCVT) -DFPRCVT > > Do you actually need $(CROSS_CC_HAS_ARMV9_FPRCVT) in the compile? > -DFPRCVT handles the compilation.
Ignore that - I forgot about the march flags. -- Alex Bennée Virtualisation Tech Lead @ Linaro
