Re: [RFC PATCH 11/13] target/hexagon: Constify CPUHexagonState in hexagon_thread_is_enabled()

[Brian Cain]

On 8/20/2026 5:47 AM, Philippe Mathieu-Daudé wrote:

Use the recently introduced env_archcpu_const() helper and
qualify @env as being const in hexagon_thread_is_enabled().

Signed-off-by: Philippe Mathieu-Daudé <phi...@oss.qualcomm.com>
---

Reviewed-by: Brian Cain <brian.c...@oss.qualcomm.com>

  target/hexagon/cpu.h | 2 +-
  target/hexagon/cpu.c | 4 ++--
  2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/target/hexagon/cpu.h b/target/hexagon/cpu.h
index c50fbb3f72a..e4f120eda17 100644
--- a/target/hexagon/cpu.h
+++ b/target/hexagon/cpu.h
@@ -216,7 +216,7 @@ G_NORETURN void hexagon_raise_exception_err(CPUHexagonState 
*env,
   * @return true if the @a thread_env hardware thread is
   * not stopped.
   */
-bool hexagon_thread_is_enabled(CPUHexagonState *thread_env);
+bool hexagon_thread_is_enabled(const CPUHexagonState *thread_env);
  uint32_t hexagon_greg_read(CPUHexagonState *env, uint32_t reg);
  void hexagon_cpu_soft_reset(CPUHexagonState *env);
  #endif
diff --git a/target/hexagon/cpu.c b/target/hexagon/cpu.c
index 9765716b516..7ae5740899b 100644
--- a/target/hexagon/cpu.c
+++ b/target/hexagon/cpu.c
@@ -345,9 +345,9 @@ static void hexagon_cpu_synchronize_from_tb(CPUState *cs,
  }

#ifndef CONFIG_USER_ONLY

-bool hexagon_thread_is_enabled(CPUHexagonState *env)
+bool hexagon_thread_is_enabled(const CPUHexagonState *env)
  {
-    HexagonCPU *cpu = env_archcpu(env);
+    const HexagonCPU *cpu = env_archcpu_const(env);
      uint32_t modectl;
      uint32_t thread_enabled_mask;
      bool E_bit;