On 8/21/26 07:58, Peter Maydell wrote:
In practice this is going to be the same as just thumb2, because v7M has v7 
which implies
thumb2, and all v7M have m_main.

v8M without the main extension exists, though we don't model any
of those CPUs at the moment. That will have ARM_FEATURE_THUMB2
(because FEATURE_V8 implies FEATURE_V7 and FEATURE_V7 implies
FEATURE_THUMB2).

Right-o.

Is it clearer as

         !(arm_dc_feature(s, ARM_FEATURE_M)
            ? arm_dc_feature(s, ARM_FEATURE_M_MAIN)
            : arm_dc_feature(s, ARM_FEATURE_THUMB2))

?

Yeah, I think so. (I actually wrote it first with nested if()s
roughly like that.)
Excellent.  With that

Reviewed-by: Richard Henderson <[email protected]>


r~

Reply via email to