On Thu, 27 Aug 2026 at 21:48, Daniel Henrique Barboza
<[email protected]> wrote:
>
> On 8/26/2026 7:11 PM, Joel Stanley wrote:
> > From: Portia Stephens <[email protected]>
> >
> > There are platforms where CPUs have different mapping of system memory.
> > The global system memory does not allow for this. This adds an optional
> > property to assign a specific memory region to a hart. This allows for a
> > machine to alias the hart's memory to system memory while the hart only
> > views memory from its own memory region.
>
> LGTM but please clarify in the commit msg that the memory region is being
> assigned to the hart array, not "to a hart".
>From the machine side you're right, but I agree with the commit
message that the memory region assigned to the hart. The property is
being set on the individual hart, not on the array:
/* Use private memory instead of system_memory if provided */
if (s->memory) {
object_property_set_link(OBJECT(&s->harts[idx]), "memory",
OBJECT(s->memory), &error_abort);
}
How about:
"This adds an optional property on the hart array to assign a specific
memory region. The array passes the region to each hart it creates,
so a machine can alias the harts' memory to system memory, while
the harts view memory from their own memory region."
>
> E.g.:
>
> "(...) This adds an optional property to assign a specific memory region to
> the
> hart array. This allows for a machine to alias the array's memory to
> system memory while the array only views memory from its own memory region."
>
>
> With the commit msg change:
>
> Reviewed-by: Daniel Henrique Barboza <[email protected]>
