On Fri, Sep 11, 2026 at 10:41 PM Brian Cain <[email protected]> wrote:
> > On 9/11/2026 5:08 PM, Taylor Simpson wrote: > > Move clear_pkt_ctx and analyze_packet out of gen_start_packet > > Precursor to adding packet validity checks to analyze_packet > > > > Signed-off-by: Taylor Simpson <[email protected]> > > --- > > Reviewed-by: Brian Cain <[email protected]> > > > Aside: I notice that you are touching "next_PC" here and it occurs to me > that I have local follow-up patches from your previous suggestion on how > to remove it. I'm prioritizing closing functionality gaps over > translation performance/codegen improvements for the time being, so it's > somewhat deep in the queue. I suppose I should bump it up a notch. > FWIW, the changes to next_PC are de minimis. The original gen_start_packet had target_ulong next_PC = ... ... ctx->next_PC = next_PC; ... if (...) { tcg_gen_movi_tl(hex_next_PC, next_PC); } When I split that function in two, the local variable and assignment to ctx->next_PC ended up in clear_pkt_ctx. So, I changed the third snippet to if (...) { tcg_gen_movi_tl(hex_next_PC, ctx->next_PC); } Thanks, Taylor
