Daniel P. Berrangé <[email protected]> writes: > On Wed, Sep 16, 2026 at 02:56:09AM -0700, Pierrick Bouvier wrote: >> On 9/16/2026 1:53 AM, Alex Bennée wrote: >> > This should trigger the building of the docker image when the user >> > calls "make check-tcg" or one of the arch specific targets such as >> > "make check-tcg-m68k-linux-user". >> > >> >> Maybe there is some confusion, patch 2 only reverts option >> enable/disable-containers + --container-command for meson. It does not >> disable container support for meson tcg tests, which is there and >> enabled by default. Thus, container image dependencies are already >> there, with ninja or make. >> >> $ ./configure && make check-tcg-m68k-linux-user --dry-run |& grep debian >> [246/1052] Generating tests/tcg/image-debian-all-test-cross with a >> custom command >> >> Given that dependencies are already there, what is the goal of current >> patch? >> >> > We still keep the internal meson dependency so individual tests can >> > launched and the docker build verified. >> > >> >> As a side note, since patch 3 removes existing meson options, there will >> be no way to disable container build and run. It might be a (new) >> problem if some people were relying on this to avoid using >> docker/podman, which is the current workaround for John Snow's issue for >> instance. >> >> At minimum, current series should at least keep meson implementation of >> --disable-containers, which implies to keep this entry in >> meson_options.txt. The rest is less important, as risk is only to skip >> tests, which is not blocking for users. > > Yes, if we're keeping meson.build rules that rely on containers, > then meson stll needs to honour the --disable-containers arg that > configure is processing now.
I've modified the revert to ensure we don't loose the options being passed down to meson. > > With regards, > Daniel -- Alex Bennée Virtualisation Tech Lead @ Linaro
