On Fri, Sep 18, 2026 at 07:29:56PM -0300, Fabiano Rosas wrote: > Pass the group name as argument to qemu_opts_parse_noisily() to make > it simmetric with qemu_opts_parse(). > > This change solves the issue of qemu_opts_parse_noisily() crashing on > a NULL return from qemu_find_opts(), which can happen when an option > is invoked for code in a module that is not loaded. > > Signed-off-by: Fabiano Rosas <[email protected]> > --- > block/monitor/block-hmp-cmds.c | 2 +- > blockdev.c | 2 +- > chardev/char-hmp-cmds.c | 5 +-- > include/qemu/option.h | 2 +- > plugins/loader.c | 2 +- > qemu-img.c | 3 +- > semihosting/config.c | 4 +- > system/vl.c | 75 ++++++++++++---------------------- > tests/unit/test-char.c | 12 ++---- > tests/unit/test-seccomp.c | 6 +-- > trace/control.c | 3 +- > ui/vnc.c | 3 +- > util/qemu-option.c | 14 ++++++- > 13 files changed, 54 insertions(+), 79 deletions(-)
Reviewed-by: Daniel P. Berrangé <[email protected]> With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|
