On Mon, 5 Oct 2026 at 22:44, Fuad Tabba <[email protected]> wrote: > On Mon, 05 Oct 2026 21:06:44 +0100, Gustavo Romero <[email protected]> wrote: > > I'm wondering if the fixes should be separated from the tests as we usually > > do, > > but feel free to wait for collecting more input from the other reviewers > > about > > it. > > Thanks! I kept each test case with the fix it covers, so each patch > carries a test case that fails without its fix. Both forms have gone > into target/arm, including my last contribution. Happy to split if you > prefer. I'll wait for more comments before doing that.
Personally I prefer "fix commit first, test commit second", especially for cases like this where the fix is a one-liner and the test case is 150 lines; but I don't object to single-commit strongly enough to require splitting it if it wouldn't otherwise require a respin. thanks -- PMM
