On 20/10/26 21:22, Stian Halseth wrote:
Hi Philippe,
On Tue, 2026-10-20 at 20:58 +0200, Philippe Mathieu-Daudé wrote:
On 20/10/26 16:55, Stian Halseth wrote:
ASR 26 returns a Compatibility Feature Register (CFR) when the
crypto feature is on. Without the crypto feature, a read keeps
strand status as before.
Reports AES, SHA1, SHA256, SHA512, CRC32C.
IIUC to keep the series bisectable, this patch should be
re-ordered *after* the "Add FOO instruction" ones, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Thanks for the review!
You're right, and I'll move this patch after the instructions patches
in v2, with your Reviewed-By.
Actually cleaner could be to add an empty CFR here, then enable
the appropriate bit in each patch adding the instruction class
(along with a test).
I'll hold off v2 for a couple of days to allow more reviewers to
respond.
/Stian
