Hi Philippe, On Wed, 2026-10-21 at 06:30 +0200, Philippe Mathieu-Daudé wrote: > > > > > > Hmm you set TCG_CALL_NO_RWG but the helper do read env->fpr[]. > > While benign in practice because fpr[] aren't tracked as global > > TCG regs, the correct declaration is using no flag at all: > > > > DEF_HELPER_1(sha1, void, env) > > DEF_HELPER_1(sha256, void, env) > > DEF_HELPER_1(sha512, void, env) > > I apologize I was wrong, your patch is correct: fpr[] is not > a TCG global. I'm having some confusion with TCG_CALL_NO_RWG. >
I came to the same conclusion. Both work, and I opted to keep the current v1's declaration for now. v2 is ready and tested. No other comments so far, so sending it. /Stian
signature.asc
Description: This is a digitally signed message part
