Re: [PATCH v4 17/18] hw/riscv/trace: update branch bit in sync messages

[Jay Chang]

>
>  size_t rv_etrace_gen_encoded_sync_msg(uint8_t *buf, uint64_t pc,
> -                                      TracePrivLevel priv_level)
> +                                      TracePrivLevel priv_level,
> +                                      bool pc_is_branch)
>  {
>      RVTraceSyncPayload payload = {.format = 0b11,
>                                    .subformat = 0b00,
> -                                  .branch = 1,
> +                                  .branch = pc_is_branch,

Spec says that
"Set to 0 if the address points to a branch instruction, and the branch was
taken. Set to 1 if the instruction is
not a branch or if the branch is not taken."

Thanks
Jay Chang