> +size_t rv_etrace_gen_encoded_format2_msg(uint8_t *buf, uint64_t addr,
> + bool notify, bool updiscon)
> +{
> + RVTraceFormat2Payload payload = {.format = 0b11,
> + .notify = notify,
> + .updiscon = updiscon};
> + RVTraceMessageHeader header = {.flow = 0, .extend = 0,
> + .length = FORMAT2_PAYLOAD_SIZE_64BITS};
>Shouldn't the format field be 0b10 for Format 2
