On Wed, Oct 28, 2026 at 07:26:33PM +0530, Prajwal N wrote: > Hi Drew, > > On 26-10-2026 23:17, Drew Fustini wrote: > > From: Nicolas Pitre <[email protected]> > > > > Add CBQRI controllers to the RISC-V virt machine. The device properties > > can be fully configured from the command line: [..] > > diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c > > index d4b501802f60..dbc0f8cfc8d7 100644 > > --- a/hw/riscv/virt.c > > +++ b/hw/riscv/virt.c > > @@ -57,6 +57,7 @@ > > #include "hw/pci-host/gpex.h" > > #include "hw/display/ramfb.h" > > #include "hw/acpi/aml-build.h" > > +#include "hw/riscv/cbqri.h" > > #include "qapi/qapi-visit-common.h" > > #include "hw/virtio/virtio-iommu.h" > > #include "hw/uefi/var-service-api.h" > > @@ -1157,6 +1158,8 @@ static void virt_machine_class_init(ObjectClass *oc, > > const void *data) > > #ifdef CONFIG_TPM > > machine_class_allow_dynamic_sysbus_dev(mc, TYPE_TPM_TIS_SYSBUS); > > #endif > > + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RISCV_CBQRI_BC); > > + machine_class_allow_dynamic_sysbus_dev(mc, TYPE_RISCV_CBQRI_CC); > > When the controller device is created dynamically through the QEMU command > line, the > corresponding device tree node must also be created. As I do not see the > implementation > to add the DT node in this series, Could you please clarify how it is > created.?
I have been using a static dtb for the purposes of testing the CBQRI support in Linux against QEMU. The Linux RFC [1] carried a "not for upstream" patch containing a dts for the virt machine with the controller nodes added. I would prefer to keep this series limited to the current scope, and I had planned to implement device tree generation in a follow-up series, as well as send an updated version of the ACPI RQSC series [2]. I'll add a note about this to the cover letter in the next rev. Thanks, Drew [1] https://lore.kernel.org/all/[email protected]/ [2] https://lore.kernel.org/all/[email protected]/
