On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 14 October 2012 21:33, Blue Swirl <blauwir...@gmail.com> wrote: >> On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell <peter.mayd...@linaro.org> >> wrote: >>> Please don't delete this function, it is the public facing interface >>> for allowing board models to attach NAND devices to the GPMC. This >>> might not be used by anything currently in mainline, but it is used >>> by the omap3 beagle and overo board models in qemu-linaro (and which >>> I will upstream eventually, honest). >> >> It could be re-added with the boards, or just disabled now with #if 0/#endif. > > It could be, but why do either of these things when the least-effort > least-change move is to just do nothing?
Actually it's not least effort, since now I have to edit the patch. I'm not sure what would be least effort, nobody does anything? ;-) > >>> In general anything in linux-user/arm/nwfpe is legacy code which >>> it's scarcely worth the effort of touching or reviewing. >> >> Adding 'static' should be only beneficial. > > Except that it's taken you time to write these patches and it > will take me time to review them. Yes, the benefit may come to the users who may get a slightly faster emulator. We, the developers, get the benefit from different things, like technical excellence or something else. > > -- PMM
