On Sun, Oct 14, 2012 at 8:55 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > On 14 October 2012 21:49, Blue Swirl <blauwir...@gmail.com> wrote: >> On Sun, Oct 14, 2012 at 8:35 PM, Peter Maydell <peter.mayd...@linaro.org> >> wrote: >>> On 14 October 2012 21:33, Blue Swirl <blauwir...@gmail.com> wrote: >>>> On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell <peter.mayd...@linaro.org> >>>> wrote: >>>>> In general anything in linux-user/arm/nwfpe is legacy code which >>>>> it's scarcely worth the effort of touching or reviewing. >>>> >>>> Adding 'static' should be only beneficial. >>> >>> Except that it's taken you time to write these patches and it >>> will take me time to review them. >> >> Yes, the benefit may come to the users who may get a slightly faster >> emulator. > > If you or any other user would like to find me some test cases > which actually use the FPA floating point emulation at all > I'd be happy to (a) add them to my test collection and (b) > test this patch... > >> We, the developers, get the benefit from different things, >> like technical excellence or something else. > > One day I might pursue technical excellence by dropping > the nwfpe code completely :-)
That would be the best option. Removed code does not need maintenance. > > -- PMM
