Am 14.10.2012 22:33, schrieb Blue Swirl: > On Sun, Oct 14, 2012 at 8:09 PM, Peter Maydell <peter.mayd...@linaro.org> > wrote: >> Please don't delete this function, it is the public facing interface >> for allowing board models to attach NAND devices to the GPMC. This >> might not be used by anything currently in mainline, but it is used >> by the omap3 beagle and overo board models in qemu-linaro (and which >> I will upstream eventually, honest). > > It could be re-added with the boards, or just disabled now with #if 0/#endif.
#if 0 would make things worse, since then no compile-time checking of the code is performed and it just rots, as seen with DPRINTF(). Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
