At Tue, 22 Jan 2013 10:38:51 +0100, Stefan Hajnoczi wrote: > > On Mon, Jan 21, 2013 at 09:23:27AM +0900, MORITA Kazutaka wrote: > > This series adds support for a unix domain socket for a connection > > between qemu and local sheepdog server. The first two patches are > > cleanups for the third patch. > > > > Changes from v1: > > - split patch for easy review > > - move set_nodelay to lib/osdep.c > > - remove redundant error checks > > - add a bit more explanation to qemu-options.hx > > > > MORITA Kazutaka (3): > > move socket_set_nodelay to osdep.c > > sheepdog: use inet_connect to simplify connect code > > sheepdog: add support for connecting to unix domain socket > > > > block/sheepdog.c | 150 > > +++++++++++++++++------------------------------- > > gdbstub.c | 5 +- > > include/qemu/sockets.h | 1 + > > qemu-char.c | 6 -- > > qemu-options.hx | 19 +++--- > > slirp/tcp_subr.c | 3 +- > > util/osdep.c | 6 ++ > > 7 files changed, 71 insertions(+), 119 deletions(-) > > Looks pretty good. > > Paolo's suggestion makes sense though - please use the same syntax as > gluster and nbd for UNIX domain sockets.
Okay, I'll add a patch to support the URI syntax, and implement UNIX domain socket support on it. Thanks, Kazutaka