On 19 December 2013 16:58, Richard Henderson <r...@twiddle.net> wrote:
> On 12/17/2013 07:12 AM, Peter Maydell wrote:
>> + TCGMemOp memop = MO_TE + size;
>
> Watch the double space (multiple occurrences).
>
>
>> + if (is_vector) {
>> + if (opc == 3) {
>> + unallocated_encoding(s);
>> + return;
>> + }
>
> In the integer LDP description I see
>
> if L:opc<0> == '01' || opc == '11' then UnallocatedEncoding();
>
> I think that opc == 3 check should be hoisted outside is_vector.
I thought I'd correctly rolled that into the opc&1 check
in the non-vector case but looking more closely you're
right. Hoisting the opc==3 out is going to be easiest.
thanks
-- PMM
