On 19 December 2013 21:04, Richard Henderson <r...@twiddle.net> wrote:
> On 12/17/2013 07:12 AM, Peter Maydell wrote:
>> +static void disas_cc(DisasContext *s, uint32_t insn)
>> {
>> + unsigned int sf, op, y, cond, rn, nzcv, is_imm;
>> + int label_continue;
>> + TCGv_i64 tcg_tmp, tcg_y, tcg_rn;
>
> Don't you get a may be used uninitialized warning for label_continue?
I know some versions of gcc tend to be bad at that,
but at least for mine (gcc-4.6.3) it doesn't warn about this
even with optimization enabled.
Is it worth pulling the assignment
label_continue = gen_new_label();
out of the if() to protect against possible less smart compilers?
thanks
-- PMM
