Re: [Qemu-devel] [PATCH 11/15] tcg-mips: Use mips64r6 instructions in tcg_out_movi

[Richard Henderson]

On 02/10/2016 03:50 AM, James Hogan wrote:

+        } else if ((disp & ~(tcg_target_long)0xffff)
+                   == sextract32(disp, 16, 16) * 0x10000) {
+            tcg_out_opc_imm(s, OPC_ALUIPC, ret, 0, disp >> 16);

I think ret and 0 are the wrong way around here. You're putting 0 in rs
(the destination register), which causes a seg fault.

Yep, thanks.


r~