On 03/09/16 13:19, Paolo Bonzini wrote: > > > On 09/03/2016 13:13, Laszlo Ersek wrote: >> David is proposing that direct pull requests be allowed on edk2-devel, >> immediately from contributors, so that the contributor may ask for >> his/her exact history to be preserved. I'm looking for examples: high >> profile projects that have adopted such a workflow *all the while* >> enforcing patch-wise reviews. Thus far I've come up empty. > > Ironically, projects using github pull requests do this. They do code > review through the website and merge with a button. The resulting > history is non-linear.
The website based review is a big minus: - email is more flexible for formulating a careful, detailed review - the review discussion is independently archived, not held hostage in a proprietary system The final result is also inferior I think: - the various feedback tags are not captured in the commit message of each individual patch We've been getting github pull requests for edk2. I'm always in a rush to reject them, lest another maintainer click the button out of oversight. I insist on keeping it all on-list. Thanks Laszlo