On 09/03/2016 13:31, Laszlo Ersek wrote: > > Ironically, projects using github pull requests do this. They do code > > review through the website and merge with a button. The resulting > > history is non-linear. > > The website based review is a big minus: > - email is more flexible for formulating a careful, detailed review > - the review discussion is independently archived, not held hostage in > a proprietary system > > The final result is also inferior I think: > - the various feedback tags are not captured in the commit message of > each individual patch > > We've been getting github pull requests for edk2. I'm always in a rush > to reject them, lest another maintainer click the button out of > oversight. I insist on keeping it all on-list.
I agree, hence the "Ironically" part. Still, the point remains that github pull requests result in a much more non-linear history than Linux or QEMU. That said, it also doesn't do exactly what David says, because the tags are recorded in the web interface only---not in the commit. Paolo
