On Fri, Mar 25, 2016 at 8:39 AM, Fam Zheng <f...@redhat.com> wrote: > On Thu, 03/24 23:48, Pooja Dhannawat wrote: > > Removing support for DEPTH != 32 from blizzard template header > > and file that includes it, as macro DEPTH == 32 only used. > > > > Signed-off-by: Pooja Dhannawat <dhannawatpoo...@gmail.com> > > Hi Pooja, a meta-comment: in the future, when post a subsequent revision, > please include what is changed since previous revision, in the cover > letter if > there are multiple patches, or under a "---" line in the commit message if > there is no cover letter. (Remember that the Signed-off-by line must still > stay > above the "---" line). > > The reason to use "---" line is for maintainers to avoid "git am" applying > the > revision changelog into git history (apparently it is meaningless out of > patch > review context). > > In this case, it would be like: > > ----8<--- > > Removing support for DEPTH != 32 from blizzard template header > and file that includes it, as macro DEPTH == 32 only used. > > Signed-off-by: Pooja Dhannawat <dhannawatpoo...@gmail.com> > > --- > > v4: Changed foo to bar, and baz to qux. [$name_of_suggester] > > ---->8--- >
Thank you Fam. I will keep this in mind from onward.
