On Wed, 2016-09-07 at 07:52 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2016-09-06 at 23:09 +0200, Thomas Huth wrote: > > > > The bad commit is: "ppc: Speed up load/store multiple" > > > > There are two "#if defined(HOST_WORDS_BIGENDIAN)" sections in this > > patch > > which are both bad: The memcpy tries to copy 32-bit values into 64- > > bit > > registers, which of course does not work (unless you compile this > > code > > for a 32-bit host only where the size of a gpr is only 32-bit). > > The instruction does that. It only copies 32-bits. I think it's > correct.
Except of course when the host is 64-bit and we enable with a 64-bit target_ulong ... ugh ;-) Drop the patch for now, I'll redo it later. Cheers, Ben.
