On 10/01/2016 05:05 AM, Artyom Tarasenko wrote:
+ uint64_t mask = 1ULL + ~(8192ULL << 3 * TTE_PGSIZE(tlb->tte));
Not the first time it has appeared in this patch series, but I find the "1 + ~" idiom to be strange. Surely plain old "-" is clearer.
r~
- Re: [Qemu-devel] [PATCH 23/29] target-sparc: implem... Richard Henderson
- [Qemu-devel] [PATCH 12/29] target-sparc: implement UA200... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 12/29] target-sparc: implem... Richard Henderson
- [Qemu-devel] [PATCH 18/29] target-sparc: use SparcV9MMU ... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 18/29] target-sparc: use Sp... Richard Henderson
- Re: [Qemu-devel] [PATCH 18/29] target-sparc: us... Artyom Tarasenko
- [Qemu-devel] [PATCH 25/29] target-sparc: implement UA200... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 25/29] target-sparc: implem... Richard Henderson
- [Qemu-devel] [PATCH 13/29] target-sparc: fix immediate U... Artyom Tarasenko
- [Qemu-devel] [PATCH 21/29] target-sparc: allow 256M size... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 21/29] target-sparc: allow ... Richard Henderson
- [Qemu-devel] [PATCH 28/29] target-sparc: move common cpu... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 28/29] target-sparc: move c... Richard Henderson
- [Qemu-devel] [PATCH 15/29] target-sparc: allow privelege... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 15/29] target-sparc: allow ... Richard Henderson
- [Qemu-devel] [PATCH 20/29] target-sparc: simplify ultras... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 20/29] target-sparc: simpli... Richard Henderson
- Re: [Qemu-devel] [PATCH 20/29] target-sparc: si... Artyom Tarasenko
- [Qemu-devel] [PATCH 22/29] target-sparc: implement auto-... Artyom Tarasenko
- Re: [Qemu-devel] [PATCH 22/29] target-sparc: implem... Richard Henderson
- [Qemu-devel] [PATCH 14/29] target-sparc: use direct addr... Artyom Tarasenko
