Hi On Wed, Jan 18, 2017 at 9:02 PM Eric Blake <ebl...@redhat.com> wrote:
> Having a named rather than anonymous C type will make it easier > to improve the testsuite in a later patch. No semantic change, > to any of the existing code or to the introspection output. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > You should move the "Example:" back to blockdev-change-medium command. Otherwise, Reviewed-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > v2: rebase to master > --- > qapi/block-core.json | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 1b3e6eb..0e31d25 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -3119,6 +3119,15 @@ > # combines blockdev-open-tray, x-blockdev-remove-medium, > # x-blockdev-insert-medium and blockdev-close-tray). > # > +# Since: 2.5 > +## > +{ 'command': 'blockdev-change-medium', > + 'data': 'BlockdevChangeMedium' } > + > + > +## > +# @BlockdevChangeMedium: > +# > # @device: #optional Block device name (deprecated, use @id > instead) > # > # @id: #optional The name or QOM path of the guest device > @@ -3165,7 +3174,7 @@ > # <- { "return": {} } > # > ## > -{ 'command': 'blockdev-change-medium', > +{ 'struct': 'BlockdevChangeMedium', > 'data': { '*device': 'str', > '*id': 'str', > 'filename': 'str', > -- > 2.9.3 > > > -- Marc-André Lureau