Eric Blake <ebl...@redhat.com> writes:
> Having a named rather than anonymous C type will make it easier
> to improve the testsuite in a later patch.
Post it together with said later patch then.
> No semantic change,
> to any of the existing code or to the introspection output.
>
> Signed-off-by: Eric Blake <ebl...@redhat.com>
>
> ---
> v2: rebase to master
> ---
> qapi/block-core.json | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 1b3e6eb..0e31d25 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -3119,6 +3119,15 @@
> # combines blockdev-open-tray, x-blockdev-remove-medium,
> # x-blockdev-insert-medium and blockdev-close-tray).
> #
> +# Since: 2.5
> +##
> +{ 'command': 'blockdev-change-medium',
> + 'data': 'BlockdevChangeMedium' }
> +
> +
> +##
> +# @BlockdevChangeMedium:
> +#
> # @device: #optional Block device name (deprecated, use @id instead)
> #
> # @id: #optional The name or QOM path of the guest device
# (since: 2.8)
#
# @filename: filename of the new image to be loaded
#
# @format: #optional, format to open the new image with (defaults to
# the probed format)
#
# @read-only-mode: #optional, change the read-only mode of the device;
defaults
# to 'retain'
#
# Since: 2.5
Isn't Since: 2.5 misleading? The anonymous type goes back to 2.5, but
the name doesn't.
> @@ -3165,7 +3174,7 @@
> # <- { "return": {} }
> #
> ##
> -{ 'command': 'blockdev-change-medium',
> +{ 'struct': 'BlockdevChangeMedium',
> 'data': { '*device': 'str',
> '*id': 'str',
> 'filename': 'str',
