On Wed, Jan 18, 2017 at 10:16:49AM -0600, Eric Blake wrote: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT()) sequences. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Alberto Garcia <be...@igalia.com> > > --- > > v2: rebase to current master > > I'm okay if you want me to break this patch into smaller pieces. > --- > include/qapi/qmp/qdict.h | 8 +++ > block.c | 59 +++++++--------- > block/archipelago.c | 4 +- > block/blkdebug.c | 6 +- > block/blkverify.c | 11 ++- > block/curl.c | 2 +- > block/file-posix.c | 8 +-- > block/file-win32.c | 4 +- > block/iscsi.c | 2 +- > block/nbd.c | 41 ++++++----- > block/nfs.c | 43 +++++------- > block/null.c | 2 +- > block/qcow2.c | 4 +- > block/quorum.c | 13 ++-- > block/ssh.c | 16 ++--- > block/vvfat.c | 10 +-- > blockdev.c | 28 ++++---- > hw/block/xen_disk.c | 2 +- > hw/usb/xen-usb.c | 12 ++-- > monitor.c | 18 ++--- > qapi/qmp-event.c | 2 +- > qemu-img.c | 6 +- > qemu-io.c | 2 +- > qemu-nbd.c | 2 +- > qobject/qdict.c | 2 +- > target/s390x/cpu_models.c | 4 +- > tests/check-qdict.c | 132 > ++++++++++++++++++------------------ > tests/test-qmp-commands.c | 30 ++++---- > tests/test-qmp-event.c | 30 ++++---- > tests/test-qobject-output-visitor.c | 6 +- > util/qemu-option.c | 6 +- > 31 files changed, 245 insertions(+), 270 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature