On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote:
Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> ---
There is no rationale in the commit body (a good commit message has a one-line summary of "what", then a paragraph stating "why", making it easier for the reviewer to check that the patch itself is the "how" that matches the commit message).
Also, when sending a new patch, it's best to send it as a new top-level thread, rather than in-reply-to an older thread that has already seen review commentary (otherwise, it's likely to get missed in the noise).
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
