On 1/5/18 11:01 pm, Eric Blake wrote: > On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote: >> Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru> >> --- > > There is no rationale in the commit body (a good commit message has a > one-line summary of "what", then a paragraph stating "why", making it > easier for the reviewer to check that the patch itself is the "how" that > matches the commit message).
Posting it in the existing thread is the rationale which explains better :) I should have made it "rfc" though as it is not really a patch but rather an email asking for comments. > Also, when sending a new patch, it's best to send it as a new top-level > thread, rather than in-reply-to an older thread that has already seen > review commentary (otherwise, it's likely to get missed in the noise). Well, normally it is fine but the context would be lost so lots need to be put to the commit log and I can see how the whole patch is dropped as useless after all. I am not arguing, just explaining :) -- Alexey
