> Subject: [PATCH v2 03/33] target/mips: Add emulation of nanoMIPS 16-bit load > and store > instructions > > From: Yongbok Kim <yongbok....@mips.com> > > Add emulation of LWXS16, LB16, SB16, LBU16, LH16, SH16, LHU16, LW16, LWSP16, > LW4X4, SW4X4, LWGP16, SWSP16, SW16, and SWGP16 instructions. > > Signed-off-by: Yongbok Kim <yongbok....@mips.com> > Signed-off-by: Aleksandar Markovic <amarko...@wavecomp.com> > Signed-off-by: Stefan Markovic <smarko...@wavecomp.com> > --- > target/mips/translate.c | 114 > ++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 114 insertions(+) >
The mixture of using extract32(), NANOMIPS_EXTRACT_XXX(), and mask/shift for decoding opcodes and registers should be streamlined, as also Richard suggested in a comment for another patch. However, this can be fixed later, after the first integration in the upstream, if the risk of regressions is too high for this stage od development of nanoMIPS support. With all these caveats, still: Reviewed-by: Aleksandar Markovic <amarko...@wavecomp.com>
