On 5/24/19 1:17 PM, Marc-André Lureau wrote: > Hi > > On Fri, May 24, 2019 at 9:41 AM Philippe Mathieu-Daudé > <phi...@redhat.com> wrote: >> >> On 5/24/19 1:40 AM, Marc-André Lureau wrote: >>> Released last month. >>> >>> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> >>> --- >>> tests/docker/dockerfiles/fedora.docker | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tests/docker/dockerfiles/fedora.docker >>> b/tests/docker/dockerfiles/fedora.docker >>> index 69d4a7f5d7..1496b68ba1 100644 >>> --- a/tests/docker/dockerfiles/fedora.docker >>> +++ b/tests/docker/dockerfiles/fedora.docker >>> @@ -1,4 +1,4 @@ >>> -FROM fedora:29 >>> +FROM fedora:30 >> >> Hmm this patch is pending for review: >> https://lists.gnu.org/archive/html/qemu-devel/2019-05/msg00819.html > > Oh I missed that. Maybe we should use "latest" to avoid bumping the > version every 6 months. > > fwiw we have different versions: > > tests/docker/dockerfiles/fedora-cris-cross.docker:FROM fedora:latest > tests/docker/dockerfiles/fedora-i386-cross.docker:FROM fedora:29 > tests/docker/dockerfiles/fedora.docker:FROM fedora:29 > > In 62559b916 "tests: update Fedora i386 cross image to Fedora 29", Daniel > said: > > Using the "latest" tag is not a good idea because this changes what > release it points to every 6 months. Together with caching of docker > builds this can cause confusion where CI has cached & built with Fedora > N, while a developer tries to reproduce a CI problem with Fedora N + 1, > or vica-verca. > > But at the same time, Daniel bumped f28 to f29 in commit 19a9978db1. > > It's confusing, do we need some stability or follow the latest?
Tracking a stable release helps to handle new compiler warnings when bisecting. See also: commit 5b9b49d7bd3e0da13e8f6d58578443a11817f56e Author: Paolo Bonzini <pbonz...@redhat.com> Date: Fri Jan 12 12:11:43 2018 +0100 docker: change Fedora base image to fedora:27 Using "fedora:latest" makes behavior different depending on when you actually pulled the image from the docker repository. In my case, the supposedly "latest" image was a Fedora 25 download from 8 months ago, and the new "test-debug" test was failing. Use "27" to improve reproducibility and make it clear when the image is obsolete. Why we don't add a new file when a new version get released? See: https://lists.gnu.org/archive/html/qemu-devel/2018-01/msg03868.html