Paolo Bonzini <pbonz...@redhat.com> writes: > On 27/05/19 10:00, Markus Armbruster wrote: >> As long as we don't have an active QOM maintainer[*], the benefit is >> low. >> >> >> [*] We need one. I'm not volunteering. > > I think Daniel, Eduardo and I could count as de facto maintainer. I > guess I could maintain it if I get two partners in crime as reviewers.
Alright, we need two volunteers for the reviewer role, and one patch to MAINTAINERS. A mention in MAINTAINERS is the traditional punishment for good work, so let's see who's been doing the work. Aha: Eduardo Habkost Marc-André Lureau Markus Armbruster Eric Blake Philippe Mathieu-Daudé Details appended. QOM is not a particularly active subsystem now: 51 commits in two years. We obviously need maintainers to review and merge patches. The nominal maintainer hasn't been doing that since 2015. Git shows the following top committers taking on / getting sucked into QOM: Markus Armbruster <arm...@redhat.com> Eduardo Habkost <ehabk...@redhat.com> Paolo Bonzini <pbonz...@redhat.com> Marc-André Lureau <marcandre.lur...@redhat.com> Eric Blake <ebl...@redhat.com> We really need nominal maintainer(s) again. Of course, *active* maintainers would be even better: I consider QOM stuck in an unhappy place where much of its potential is still potential. But let's start small. Volunteers for the reviewer role, please step forward :) The details I promised: Output of "scripts/get_maintainer.pl --git --git-since='2-years-ago' | grep commit_signer" sorted by file size: = qom/object.c = "Marc-André Lureau" <marcandre.lur...@redhat.com> (commit_signer:20/36=56%) Markus Armbruster <arm...@redhat.com> (commit_signer:15/36=42%) Eric Blake <ebl...@redhat.com> (commit_signer:14/36=39%) Eduardo Habkost <ehabk...@redhat.com> (commit_signer:14/36=39%) "Philippe Mathieu-Daudé" <phi...@redhat.com> (commit_signer:9/36=25%) = include/qom/object.h = Eduardo Habkost <ehabk...@redhat.com> (commit_signer:9/18=50%) "Marc-André Lureau" <marcandre.lur...@redhat.com> (commit_signer:8/18=44%) Igor Mammedov <imamm...@redhat.com> (commit_signer:6/18=33%) Markus Armbruster <arm...@redhat.com> (commit_signer:6/18=33%) David Gibson <da...@gibson.dropbear.id.au> (commit_signer:5/18=28%) = include/qom/object_interfaces.h = Eduardo Habkost <ehabk...@redhat.com> (commit_signer:8/5=100%) Igor Mammedov <imamm...@redhat.com> (commit_signer:3/5=60%) "Marc-André Lureau" <marcandre.lur...@redhat.com> (commit_signer:2/5=40%) "Philippe Mathieu-Daudé" <f4...@amsat.org> (commit_signer:2/5=40%) Eric Blake <ebl...@redhat.com> (commit_signer:1/5=20%) = qom/object_interfaces.c = Eric Blake <ebl...@redhat.com> (commit_signer:9/12=75%) "Marc-André Lureau" <marcandre.lur...@redhat.com> (commit_signer:7/12=58%) Markus Armbruster <arm...@redhat.com> (commit_signer:7/12=58%) Eduardo Habkost <ehabk...@redhat.com> (commit_signer:6/12=50%) "Philippe Mathieu-Daudé" <phi...@redhat.com> (commit_signer:4/12=33%) = qom/qom-qobject.c = = include/qom/qom-qobject.h = = qom/trace-events = Stefan Hajnoczi <stefa...@redhat.com> (commit_signer:2/2=100%) "Philippe Mathieu-Daudé" <phi...@redhat.com> (commit_signer:2/2=100%) Markus Armbruster <arm...@redhat.com> (commit_signer:1/2=50%) Michael Tokarev <m...@tls.msk.ru> (commit_signer:1/2=50%) = qom/Makefile.objs =