On 6/7/19 8:59 AM, Markus Armbruster wrote: [...] > QOM is not a particularly active subsystem now: 51 commits in two years. > > We obviously need maintainers to review and merge patches. The nominal > maintainer hasn't been doing that since 2015. Git shows the following > top committers taking on / getting sucked into QOM: > > Markus Armbruster <arm...@redhat.com> > Eduardo Habkost <ehabk...@redhat.com> > Paolo Bonzini <pbonz...@redhat.com> > Marc-André Lureau <marcandre.lur...@redhat.com> > Eric Blake <ebl...@redhat.com> > > We really need nominal maintainer(s) again. > > Of course, *active* maintainers would be even better: I consider QOM > stuck in an unhappy place where much of its potential is still > potential. > > But let's start small. Volunteers for the reviewer role, please step > forward :) > > > > The details I promised: > > Output of "scripts/get_maintainer.pl --git --git-since='2-years-ago' | > grep commit_signer" sorted by file size: > [...] > = include/qom/object_interfaces.h = > Eduardo Habkost <ehabk...@redhat.com> (commit_signer:8/5=100%) > Igor Mammedov <imamm...@redhat.com> (commit_signer:3/5=60%) > "Marc-André Lureau" <marcandre.lur...@redhat.com> (commit_signer:2/5=40%) > "Philippe Mathieu-Daudé" <f4...@amsat.org> (commit_signer:2/5=40%) > Eric Blake <ebl...@redhat.com> (commit_signer:1/5=20%)
get_maintainer's commit_signer is lying... [...] > = qom/trace-events = > Stefan Hajnoczi <stefa...@redhat.com> (commit_signer:2/2=100%) > "Philippe Mathieu-Daudé" <phi...@redhat.com> (commit_signer:2/2=100%) > Markus Armbruster <arm...@redhat.com> (commit_signer:1/2=50%) > Michael Tokarev <m...@tls.msk.ru> (commit_signer:1/2=50%) This 'git log -p' history of this file is very interesting...