On 6/21/19 6:34 PM, Andrew Jones wrote: > Suggested-by: Dave Martin <dave.mar...@arm.com> > Signed-off-by: Andrew Jones <drjo...@redhat.com> > --- > target/arm/helper.c | 1 + > 1 file changed, 1 insertion(+)
Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > diff --git a/target/arm/helper.c b/target/arm/helper.c > index df4276f5f6ca..edba94004e0b 100644 > --- a/target/arm/helper.c > +++ b/target/arm/helper.c > @@ -5319,6 +5319,7 @@ static void zcr_write(CPUARMState *env, const > ARMCPRegInfo *ri, > int new_len; > > /* Bits other than [3:0] are RAZ/WI. */ > + QEMU_BUILD_BUG_ON(ARM_MAX_VQ > 16); > raw_write(env, ri, value & 0xf); > Re down-thread conversation, I think this is the nice easy way to make sure that the 0xf is modified if we ever decide to support larger vectors. I *think* that we could write ARM_MAX_VQ - 1 here, but I'm pretty sure there are a few other places where we assume that we only need 4 bits to store this value. Anyway, we'd definitely need to audit the code to allow ARM_MAX_VQ to change. r~
