Patchew URL: https://patchew.org/QEMU/20191104151323.9883-1-cr...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test Type: series Message-id: 20191104151323.9883-1-cr...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 8675afa Acceptance test: add "boot_linux" tests 409affc Acceptance tests: depend on qemu-img 58c0f47 Acceptance tests: add the build directory to the system PATH 236ecfa Acceptance tests: keep a stable reference to the QEMU build dir 6a147b4 Acceptance tests: use relative location for tests bcd92a3 Acceptance tests: use avocado tags for machine type 0f52135 Acceptance tests: introduce utility method for tags unique vals 050f1d1 Acceptance test x86_cpu_model_versions: use default vm === OUTPUT BEGIN === 1/8 Checking commit 050f1d1ea660 (Acceptance test x86_cpu_model_versions: use default vm) ERROR: line over 90 characters #47: FILE: tests/acceptance/x86_cpu_model_versions.py:248: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #61: FILE: tests/acceptance/x86_cpu_model_versions.py:256: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #76: FILE: tests/acceptance/x86_cpu_model_versions.py:265: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #90: FILE: tests/acceptance/x86_cpu_model_versions.py:273: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,-arch-capabilities') ERROR: line over 90 characters #105: FILE: tests/acceptance/x86_cpu_model_versions.py:282: + self.vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #120: FILE: tests/acceptance/x86_cpu_model_versions.py:290: + self.vm.add_args('-cpu', 'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #123: FILE: tests/acceptance/x86_cpu_model_versions.py:293: + 'pc-i440fx-4.0 + Cascadelake-Server-v2 should have arch-capabilities') ERROR: line over 90 characters #136: FILE: tests/acceptance/x86_cpu_model_versions.py:299: + self.vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #139: FILE: tests/acceptance/x86_cpu_model_versions.py:302: + 'pc-i440fx-4.0 + Cascadelake-Server-v1,+arch-capabilities should have arch-capabilities') ERROR: line over 90 characters #150: FILE: tests/acceptance/x86_cpu_model_versions.py:307: + self.vm.add_args('-cpu', 'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off,-arch-capabilities') total: 10 errors, 0 warnings, 134 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit 0f5213583c78 (Acceptance tests: introduce utility method for tags unique vals) 3/8 Checking commit bcd92a334692 (Acceptance tests: use avocado tags for machine type) WARNING: line over 80 characters #59: FILE: tests/acceptance/avocado_qemu/__init__.py:119: + default=self._get_unique_tag_val('machine')) total: 0 errors, 1 warnings, 450 lines checked Patch 3/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/8 Checking commit 6a147b4b2eb1 (Acceptance tests: use relative location for tests) 5/8 Checking commit 236ecfa68ee0 (Acceptance tests: keep a stable reference to the QEMU build dir) ERROR: line over 90 characters #48: FILE: tests/acceptance/avocado_qemu/__init__.py:19: +SRC_ROOT_DIR = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(__file__)))) total: 1 errors, 0 warnings, 8 lines checked Patch 5/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/8 Checking commit 58c0f475d5ec (Acceptance tests: add the build directory to the system PATH) 7/8 Checking commit 409affc034ce (Acceptance tests: depend on qemu-img) 8/8 Checking commit 8675afa0dead (Acceptance test: add "boot_linux" tests) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 WARNING: line over 80 characters #122: FILE: tests/acceptance/boot_linux.py:76: + console_drainer = datadrainer.LineLogger(self.vm.console_socket.fileno(), WARNING: line over 80 characters #123: FILE: tests/acceptance/boot_linux.py:77: + logger=self.log.getChild('console')) WARNING: line over 80 characters #126: FILE: tests/acceptance/boot_linux.py:80: + cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), self.name) total: 0 errors, 4 warnings, 179 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191104151323.9883-1-cr...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com