On 11/4/19 4:13 PM, Cleber Rosa wrote:
So that when binaries such as qemu-img are searched for, those in the
build tree will be favored. As a clarification, SRC_ROOT_DIR is
dependent on the location from where tests are executed, so they are
equal to the build directory if one is being used.
The original motivation is that Avocado libraries such as
avocado.utils.vmimage.get() may use the matching binaries, but it may
also apply to any other binary that test code may eventually attempt
to execute.
Signed-off-by: Cleber Rosa <cr...@redhat.com>
---
tests/acceptance/avocado_qemu/__init__.py | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/acceptance/avocado_qemu/__init__.py
b/tests/acceptance/avocado_qemu/__init__.py
index 17ce583c87..a4bb796a47 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -110,6 +110,12 @@ class Test(avocado.Test):
return None
def setUp(self):
+ # Some utility code uses binaries from the system's PATH. For
+ # instance, avocado.utils.vmimage.get() uses qemu-img, to
+ # create a snapshot image. This is a transparent way of
+ # making sure those utilities find and use binaries on the
+ # build tree by default.
+ os.environ['PATH'] = '%s:%s' % (SRC_ROOT_DIR, os.environ['PATH'])
But qemu-img is compiled in BUILD_ROOT_DIR, isn't it?
Maybe we should pass its path by argument, such --qemu-img /path/to/it.
self._vms = {}
self.arch = self.params.get('arch',
