On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 9:00 AM, Michal Privoznik wrote: >> In v4.2.0-246-ged9e923c3c the SMM property was moved from PC > > Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c.
This depends on how you format the hash :-) I've used 'git describe ed9e923c3c' because I find it more readable for us humans (at least we see what version the commit was introduced in). But I don't know what the praxis is in qemu. > >> machine class to x86 machine class. Makes sense, but the change >> was too aggressive: in target/i386/kvm.c:kvm_arch_init() it >> altered check which sets SMRAM if given machine has SMM enabled. >> The line that detects whether given machine object is class of >> PC_MACHINE was removed from the check. This makes qemu try to >> enable SMRAM for all machine types, which is not what we want. >> > > Fixes: ed9e923c3c > Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com> Thanks, Michal
