On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: > On 12/30/19 10:35 AM, Michal Prívozník wrote: >> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: >>> On 12/30/19 9:00 AM, Michal Privoznik wrote: >>>> In v4.2.0-246-ged9e923c3c the SMM property was moved from PC >>> >>> Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. >> >> This depends on how you format the hash :-) >> I've used 'git describe ed9e923c3c' because I find it more readable for >> us humans (at least we see what version the commit was introduced in). >> But I don't know what the praxis is in qemu. > > Hmm I never used it. Your explanation makes sense, but the tag confused > me because I don't have it locally. However git (and gitk) seems clever > enough to only use the useful part:
The v4.2.0 tag is in origin. I wonder how come you do not have it. > > $ git show randomcrap-ged9e923c3c > commit ed9e923c3c9a2c50c4e82ba178b3fb1feba56867 > Author: Paolo Bonzini <pbonz...@redhat.com> > Date: Thu Dec 12 17:28:01 2019 +0100 > > x86: move SMM property to X86MachineState > > FYI My output is different: > > $ git describe ed9e923c3c > pull-target-arm-20191216-1-199-ged9e923c3c You may want to use 'git describe --tags --match "v*" $commit' But again, feel free to change it to whatever you/committer wants. Michal
