On 30/12/19 14:17, Michal Prívozník wrote: > On 12/30/19 10:45 AM, Philippe Mathieu-Daudé wrote: >> On 12/30/19 10:35 AM, Michal Prívozník wrote: >>> On 12/30/19 9:41 AM, Philippe Mathieu-Daudé wrote: >>>> On 12/30/19 9:00 AM, Michal Privoznik wrote: >>>>> In v4.2.0-246-ged9e923c3c the SMM property was moved from PC >>>> >>>> Typo v4.2.0-246-ged9e923c3c -> ed9e923c3c. >>> >>> This depends on how you format the hash :-) >>> I've used 'git describe ed9e923c3c' because I find it more readable for >>> us humans (at least we see what version the commit was introduced in). >>> But I don't know what the praxis is in qemu. >> >> Hmm I never used it. Your explanation makes sense, but the tag confused >> me because I don't have it locally. However git (and gitk) seems clever >> enough to only use the useful part: > > The v4.2.0 tag is in origin. I wonder how come you do not have it. > >> >> $ git show randomcrap-ged9e923c3c
Cool, I didn't know this. I usually format it like ed9e923c3c ("x86: move SMM property to X86MachineState", 2019-12-17) I can see why most developers don't use "git describe", because at least those that also are maintainers will often have intermediate tags after a release. Anyway I've queued this patch, thanks. Paolo