Patchew URL: https://patchew.org/QEMU/20200507114824.788942-1-npig...@gmail.com/
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200507114824.788942-1-npig...@gmail.com Subject: [PATCH] ppc/pnv: Fix NMI system reset SRR1 value Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' fbe72cb ppc/pnv: Fix NMI system reset SRR1 value === OUTPUT BEGIN === ERROR: code indent should never use tabs #35: FILE: hw/ppc/pnv.c:1991: +^I * Power-save wakeups, as indicated by non-zero SRR1[46:47] put the$ ERROR: code indent should never use tabs #36: FILE: hw/ppc/pnv.c:1992: +^I * wakeup reason in SRR1[42:45], system reset is indicated with 0b0100$ ERROR: code indent should never use tabs #37: FILE: hw/ppc/pnv.c:1993: +^I * (PPC_BIT(43)).$ ERROR: code indent should never use tabs #38: FILE: hw/ppc/pnv.c:1994: +^I */$ ERROR: line over 90 characters #40: FILE: hw/ppc/pnv.c:1996: + warn_report("ppc_cpu_do_system_reset does not set system reset wakeup reason"); ERROR: code indent should never use tabs #45: FILE: hw/ppc/pnv.c:2001: +^I * For non-powersave system resets, SRR1[42:45] are defined to be$ ERROR: code indent should never use tabs #46: FILE: hw/ppc/pnv.c:2002: +^I * implementation-dependent. The POWER9 User Manual specifies that$ ERROR: code indent should never use tabs #47: FILE: hw/ppc/pnv.c:2003: +^I * an external (SCOM driven, which may come from a BMC nmi command or$ ERROR: code indent should never use tabs #48: FILE: hw/ppc/pnv.c:2004: +^I * another CPU requesting a NMI IPI) system reset exception should be$ ERROR: code indent should never use tabs #49: FILE: hw/ppc/pnv.c:2005: +^I * 0b0010 (PPC_BIT(44)).$ total: 10 errors, 0 warnings, 32 lines checked Commit fbe72cb9d465 (ppc/pnv: Fix NMI system reset SRR1 value) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200507114824.788942-1-npig...@gmail.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com