On 6/25/20 2:15 PM, Lijun Pan wrote:
>
>
>> On Jun 25, 2020, at 1:37 PM, Richard Henderson
>> <richard.hender...@linaro.org> wrote:
>>
>> On 6/25/20 10:00 AM, Lijun Pan wrote:
>>> +#define VDIV_MOD_DO(name, op, element, sign, bit) \
>>> + void helper_v##name(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b) \
>>> + { \
>>> + int i; \
>>> + \
>>> + \
>>> + for (i = 0; i < ARRAY_SIZE(r->element); i++) { \
>>> + if (unlikely((b->element[i] == 0) || \
>>> + (sign && \
>>> + (b->element[i] == UINT##bit##_MAX) && \
>>> + (a->element[i] == INT##bit##_MIN)))) \
>>> + continue; \
>>> + r->element[i] = a->element[i] op b->element[i]; \
>>> + } \
>>> + }
>>
>> Missing braces for the if. Extra blank line before the for.
>
> No, the braces are enough.
No they are not. See CODING_STYLE.rst.
r~
